Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "add_inheritable_capabilities" option #6236

Merged

Conversation

haircommander
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

add an option to re-add the inheritable capabilities. there are situations where users previously expected non-root users to get these capabilities, which adding them to the inheritable list enabled.

related to kubernetes/kubernetes#111196 and GHSA-4hj2-r2pm-3hc6

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add an option "add_inheritable_capabilities" which adds added capabilities to the inheritable list as well. As of CRI-O 1.24.0, CRI-O drops the inheritable capabilities to fix CVE-2022-27652 . However, this can cause regressions in workloads that attempt to pass capabilities to non-root users through inheritable capabilities. 

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 19, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #6236 (6041547) into main (a05656a) will decrease coverage by 0.03%.
The diff coverage is 25.92%.

❗ Current head 6041547 differs from pull request most recent head 406f367. Consider uploading reports for the commit 406f367 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6236      +/-   ##
==========================================
- Coverage   43.62%   43.59%   -0.04%     
==========================================
  Files         122      122              
  Lines       13583    13607      +24     
==========================================
+ Hits         5926     5932       +6     
- Misses       7017     7031      +14     
- Partials      640      644       +4     

Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/test ci-integration
/test ci-cgroupv2-e2e
/override ci/prow/ci-e2e-conmonrs

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs

In response to this:

/test ci-integration
/test ci-cgroupv2-e2e
/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/override ci/prow/e2e-agnostic

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic

In response to this:

/override ci/prow/e2e-agnostic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/cherry-pick release-1.25

@openshift-cherrypick-robot

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/override ci/prow/ci-rhel-integration
/override ci/prow/ci-e2e-conmonrs

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration

In response to this:

/override ci/prow/ci-rhel-integration
/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/override ci/prow/ci-e2e-conmonrs

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs

In response to this:

/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit a7da0a6 into cri-o:main Sep 22, 2022
@openshift-cherrypick-robot

@haircommander: new pull request created: #6249

In response to this:

/cherry-pick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants