New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "add_inheritable_capabilities" option #6236
add "add_inheritable_capabilities" option #6236
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6236 +/- ##
==========================================
- Coverage 43.62% 43.59% -0.04%
==========================================
Files 122 122
Lines 13583 13607 +24
==========================================
+ Hits 5926 5932 +6
- Misses 7017 7031 +14
- Partials 640 644 +4 |
Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
6041547
to
406f367
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ci-integration |
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-agnostic |
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.25 |
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/ci-rhel-integration |
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/ci-e2e-conmonrs |
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@haircommander: new pull request created: #6249 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add an option to re-add the inheritable capabilities. there are situations where users previously expected non-root users to get these capabilities, which adding them to the inheritable list enabled.
related to kubernetes/kubernetes#111196 and GHSA-4hj2-r2pm-3hc6
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?