Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.23] resource store: save stage of resource creation and report to callers #6303

Merged

Conversation

haircommander
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CRI-O now logs the stage of container or pod creation under system load. This allows users to find why their creation requests are stalling.

stages are a mechanims that a watcher can see the stage
a pod or container creation is at. This will help aid in debugging
under load.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@haircommander
Copy link
Member Author

@saschagrunert PTAL

@haircommander
Copy link
Member Author

/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@haircommander haircommander added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4a08070 into cri-o:release-1.23 Oct 17, 2022
@haircommander
Copy link
Member Author

/cherry-pick release-1.22

@openshift-cherrypick-robot

@haircommander: #6303 failed to apply on top of branch "release-1.22":

Applying: resource store: introduce stages
Applying: resource store: return stage when a watcher is requested
Using index info to reconstruct a base tree...
M	server/utils.go
Falling back to patching base and 3-way merge...
Auto-merging server/utils.go
Applying: server: update stages according to progress with resource creation
Using index info to reconstruct a base tree...
M	server/container_create.go
M	server/container_create_linux.go
M	server/sandbox_run_linux.go
Falling back to patching base and 3-way merge...
Auto-merging server/sandbox_run_linux.go
Auto-merging server/container_create_linux.go
CONFLICT (content): Merge conflict in server/container_create_linux.go
Auto-merging server/container_create.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 server: update stages according to progress with resource creation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants