Support RegistryUnavailable type
#6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
openshift-ci
bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6842 +/- ##
==========================================
- Coverage 49.75% 49.60% -0.16%
==========================================
Files 127 127
Lines 14994 14971 -23
==========================================
- Hits 7461 7426 -35
- Misses 6645 6655 +10
- Partials 888 890 +2 |
|
/test e2e-gcp-ovn |
|
/unhold @cri-o/cri-o-maintainers PTAL |
openshift-ci
bot
removed
the
do-not-merge/hold
saschagrunert
force-pushed
the
registry-unavailable
branch
from
66c7547
to
eda824d
Compare
If we agree on the fix in kubernetes/kubernetes#117612, then we can support the `RegistryUnavailable` error message as well. This has the benefit that we display the information directly to the end user as better error indicator. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
registry-unavailable
branch
from
eda824d
to
bf23f5c
Compare
|
@haircommander PTAL again |
|
thank you! /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
If we agree on the fix in kubernetes/kubernetes#117612, then we can support the
RegistryUnavailableerror message as well. This has the benefit that we display the information directly to the end user as better error indicator./hold
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?