Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] Add debug to identify when a relabel was not requested #6965

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #6494

/assign sohankunkerkar

Adds debug log to identify when a relabel was not requested

This makes it easier to verify whether relabel is being
done or not for a volume.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 25, 2023
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl May 25, 2023 15:46
@sohankunkerkar
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #6965 (6cc4c5a) into release-1.24 (ebd7766) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.24    #6965   +/-   ##
=============================================
  Coverage         42.88%   42.89%           
=============================================
  Files               124      124           
  Lines             12749    12751    +2     
=============================================
+ Hits               5468     5470    +2     
  Misses             6755     6755           
  Partials            526      526           

Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 83c2c42 into cri-o:release-1.24 May 25, 2023
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants