New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the crio api to reflect image store #7401
update the crio api to reflect image store #7401
Conversation
Hi @kannon92. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7401 +/- ##
==========================================
- Coverage 49.16% 49.15% -0.01%
==========================================
Files 138 138
Lines 15710 15712 +2
==========================================
Hits 7724 7724
- Misses 7057 7059 +2
Partials 929 929 |
server/inspect.go
Outdated
// TODO: This should probably be something to do with image store | ||
// Have to look into oci.container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this TODO still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed up a fix to drop this. Thanks for catching that.
a571cde
to
d8b098d
Compare
Signed-off-by: Kevin Hannon<kehannon@redhat.com>
d8b098d
to
5320ed7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This exposes imagestore to clients of CRI-O.
google/cadvisor#3395 is one example of someone using this.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?