Make ImageStatusByName race-free

[mtrmac]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, ImageStatusByName looks up the incoming name three times (once in GetStoreImage, once in NewImage, once in NewImageSource. If the name uses a tag and not a digest, that can result reading data from three different images, making the resulting ImageResult inconsistent.

A fix for this requires a new storage.ResolveReference function in c/image, being added in containers/image#2056 .

This PR is currently a proof-of-concept before merging that c/image feature, depending on an unmerged c/image PR.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

It seems possible to me that we don’t actually need this for signature verification (as long as we get one StorageID, we have something to work with, and the other fields of ImageResult might not matter), but it is just simpler for me fix ImageStatusByName than to worry about the details of that situation.

And I think CRI-O benefits form this fix either way.

Cc: @saschagrunert

Does this PR introduce a user-facing change?

None

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Merging #7435 (19cae30) into main (7499cc2) will decrease coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is 65.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7435      +/-   ##
==========================================
- Coverage   49.15%   49.14%   -0.01%     
==========================================
  Files         145      145              
  Lines       15808    15813       +5     
==========================================
+ Hits         7770     7771       +1     
- Misses       7105     7106       +1     
- Partials      933      936       +3     

[mtrmac]

Note to self:

[FAILED] failed to get image status: rpc error: code = Unknown desc = reference "[overlay@/tmp/tmp.BdnzWSMRdG/crio+/tmp/tmp.BdnzWSMRdG/crio-run]registry.k8s.io/e2e-test-images/busybox:1.29-2" does not resolve to an image ID: identifier is not an image

Those are real enough, ResolveReference returns a different error than GetStoreImage used to, and ImageStatus looks for that error.

[mtrmac]

containers/image#2056 was merged, but this now depends on #7460 .

[mtrmac]

Prerequisites are merged, this is now ready for review.

[saschagrunert]

Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saschagrunert]

/retest

[saschagrunert]

/retest

[mtrmac]

/retest