[release-1.27] server: allow Bidirectional mounts that contain storage root

[kwilczynski]

This is a manual cherry-pick of #7076 and #7408

/assign kwilczynski

- Set mount type HostToContainer for mounts that include container storage root
- Fix a bug where CRI-O would override a Bidirectional mount in favor of a HostToContainer if the mount contained the host's container storage

[openshift-ci-robot]

@kwilczynski: This pull request explicitly references no jira issue.

In response to this:

This is a manual cherry-pick of #7076 and #7408

/assign kwilczynski

- Set mount type HostToContainer for mounts that include container storage root
- Fix a bug where CRI-O would override a Bidirectional mount in favor of a HostToContainer if the mount contained the host's container storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #7457 (dde9ff5) into release-1.27 (9b9c375) will increase coverage by 0.01%.
Report is 2 commits behind head on release-1.27.
The diff coverage is 72.72%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.27    #7457      +/-   ##
================================================
+ Coverage         49.30%   49.31%   +0.01%     
================================================
  Files               128      128              
  Lines             15187    15196       +9     
================================================
+ Hits               7488     7494       +6     
- Misses             6801     6803       +2     
- Partials            898      899       +1     

[kwilczynski]

/lgtm

[openshift-ci]

@kwilczynski: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[haircommander]

hm why did we backport this? was someone asking for this behavior? I worry about having introduced more issues (even past the one that is now fixed) and I'm not sure we should introduce such instability into this branch

[kwilczynski]

Hi @haircommander,

hm why did we backport this? was someone asking for this behavior? I worry about having introduced more issues (even past the one that is now fixed) and I'm not sure we should introduce such instability into this branch

What do you mean when you say "instability"? Do you foresee issues?

I am asking as we backported this to release 1.28, and we are about to cut a 1.28.2 release.

Similarly, with 1.27.2 - it was with anticipation of this new release and the fact that we made a backport to a different release branch I decided to backport this fix. Both are our active releases, and this fixes issues with some CSI that people use.

If we weren't entirely sure about this, why backport to 1.28 and not just leave it on the main branch?

Nevertheless, we can revert before you cut the 1.27.2 release. 😄

[haircommander]

FWIW: the initial commit here is kind of a feature. It fixes an issue when users mount /host and aren't able to see updates to /var/lib/containers. that said, I think it's fine. let's leave it for now