Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: set default pids limit to -1 #7503

Merged
merged 1 commit into from Dec 5, 2023
Merged

config: set default pids limit to -1 #7503

merged 1 commit into from Dec 5, 2023

Conversation

haircommander
Copy link
Member

even though the oci runtime spec says 0 should be unlimited, runc does not interpret it as such

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update pids_limit field to be -1 by default. Even though it's deprecated, having -1 is correctly interpreted by runc as unlimited, as the original intent of the 0 value was meant to be.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2023
@haircommander
Copy link
Member Author

alternative to opencontainers/runc#4015 and opencontainers/runc#4023 cc @kolyshkin

@haircommander haircommander mentioned this pull request Nov 21, 2023
Closed
@haircommander
config: set default pids limit to -1
37b3754 
even though the oci runtime spec says 0 should be unlimited, runc does not interpret it
as such

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander added this to the 1.29 milestone Nov 28, 2023
@haircommander haircommander marked this pull request as ready for review November 28, 2023 19:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@haircommander
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@kwilczynski
Copy link
Member

/approve

@kwilczynski
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@sohankunkerkar
Copy link
Member

/retest

@haircommander
Copy link
Member Author

/override ci/prow/ci-fedora-integration

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-fedora-integration

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member 

/test ci-cgroupv2-e2e-crun

@sohankunkerkar
Copy link
Member

/retest

@sohankunkerkar
Copy link
Member

/retest

2 similar comments
@sohankunkerkar
Copy link
Member

/retest

@saschagrunert
Copy link
Member

/retest

@haircommander
Copy link
Member Author

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/override ci/prow/e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/override ci/prow/ci-fedora-kata

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-kata

In response to this:

/override ci/prow/ci-fedora-kata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/test ci-e2e

@haircommander
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 98264a1 into cri-o:main Dec 5, 2023
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haircommander @kwilczynski @sohankunkerkar @saschagrunert