Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: remove deleted containers from OOM count metrics #7656

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

haircommander
Copy link
Member

to prevent an ever growing vector and cardinality

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

cleanup deleted container from `container_runtime_crio_containers_oom` metric, preventing leaks and high cardinality

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 4, 2024
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 4, 2024
@haircommander
Copy link
Member Author

fixes #7249

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #7656 (7d335ea) into main (75fcda9) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7656      +/-   ##
==========================================
- Coverage   48.02%   48.00%   -0.03%     
==========================================
  Files         145      145              
  Lines       16241    16248       +7     
==========================================
  Hits         7800     7800              
- Misses       7499     7506       +7     
  Partials      942      942              

to prevent an ever growing vector and cardinality

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander marked this pull request as ready for review January 5, 2024 20:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2024
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl January 5, 2024 21:00
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sohankunkerkar
Copy link
Member

/retest

1 similar comment
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/override ci/prow/ci-cgroupv2-integration

Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-cgroupv2-integration

In response to this:

/override ci/prow/ci-cgroupv2-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 4a13759 into cri-o:main Jan 26, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants