-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: remove deleted containers from OOM count metrics #7656
Conversation
Skipping CI for Draft Pull Request. |
fixes #7249 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7656 +/- ##
==========================================
- Coverage 48.02% 48.00% -0.03%
==========================================
Files 145 145
Lines 16241 16248 +7
==========================================
Hits 7800 7800
- Misses 7499 7506 +7
Partials 942 942 |
5dcacfc
to
7d335ea
Compare
to prevent an ever growing vector and cardinality Signed-off-by: Peter Hunt <pehunt@redhat.com>
7d335ea
to
e510f38
Compare
/retest |
@cri-o/cri-o-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/override ci/prow/ci-cgroupv2-integration |
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-cgroupv2-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
to prevent an ever growing vector and cardinality
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?