Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2023: add metrics_host to config #7677

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Jan 10, 2024

Allows for localhost only metrics.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add support for --metrics-host.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 10, 2024
@kwilczynski
Copy link
Member

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #7677 (973b046) into main (501048d) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 76.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7677   +/-   ##
=======================================
  Coverage   47.97%   47.98%           
=======================================
  Files         145      145           
  Lines       16248    16260   +12     
=======================================
+ Hits         7795     7802    +7     
- Misses       7510     7513    +3     
- Partials      943      945    +2     

@rphillips rphillips changed the title WIP: add metrics_host to config OCPNODE-2023: add metrics_host to config Jan 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2024
@openshift-ci-robot
Copy link

@rphillips: This pull request references OCPNODE-2023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Allows for localhost only metrics.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
@haircommander
Copy link
Member

docs need updating: https://github.com/cri-o/cri-o/actions/runs/7544557013/job/20538161526?pr=7677
I believe there is a --metrics-port cli flag, should we have a cli flag for this as well?

@rphillips rphillips force-pushed the add_metrics_host branch 5 times, most recently from b410cca to 973b046 Compare January 17, 2024 17:17
Allows for localhost only metrics.

Signed-off-by: Ryan Phillips <rphillips@redhat.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2024
@sohankunkerkar
Copy link
Member

@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 18, 2024
Signed-off-by: Ryan Phillips <rphillips@redhat.com>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 18, 2024
docs/crio.8.md Outdated Show resolved Hide resolved
Signed-off-by: Ryan Phillips <rphillips@redhat.com>
@haircommander
Copy link
Member

/approve

LGTM, thanks! @cri-o/cri-o-maintainers PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor Author

/test ci-cgroupv2-e2e-crun

@sohankunkerkar
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 5aff11c into cri-o:main Jan 18, 2024
60 checks passed
@rphillips
Copy link
Contributor Author

/cherry-pick release-1.29

@openshift-cherrypick-robot

@rphillips: new pull request created: #7700

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants