-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPNODE-2023: add metrics_host to config #7677
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7677 +/- ##
=======================================
Coverage 47.97% 47.98%
=======================================
Files 145 145
Lines 16248 16260 +12
=======================================
+ Hits 7795 7802 +7
- Misses 7510 7513 +3
- Partials 943 945 +2 |
afe51d5
to
302852b
Compare
@rphillips: This pull request references OCPNODE-2023 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
docs need updating: https://github.com/cri-o/cri-o/actions/runs/7544557013/job/20538161526?pr=7677 |
b410cca
to
973b046
Compare
Allows for localhost only metrics. Signed-off-by: Ryan Phillips <rphillips@redhat.com>
973b046
to
8dea353
Compare
@rphillips could you handle these two failures? |
Signed-off-by: Ryan Phillips <rphillips@redhat.com>
bc5c777
to
3cbaa52
Compare
Signed-off-by: Ryan Phillips <rphillips@redhat.com>
adcebac
to
1b97544
Compare
/approve LGTM, thanks! @cri-o/cri-o-maintainers PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kwilczynski, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ci-cgroupv2-e2e-crun |
/retest |
/cherry-pick release-1.29 |
@rphillips: new pull request created: #7700 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allows for localhost only metrics.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?