Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --seccomp-use-default-when-empty/seccomp_use_default_when_empty option #7830

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Remove --seccomp-use-default-when-empty/seccomp_use_default_when_empty option #7830

merged 1 commit into from
Mar 1, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

The option has been deprecated for a while and will now be removed in v1.30.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Removed `--seccomp-use-default-when-empty`/`seccomp_use_default_when_empty` option in favor of the `SeccompDefault` feature in Kubernetes.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/deprecation labels Mar 1, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@saschagrunert saschagrunert changed the title Remove --seccomp-use-default-when-empty option Remove --seccomp-use-default-when-empty/seccomp_use_default_when_empty option Mar 1, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited

Codecov Report

Merging #7830 (03c4bca) into main (06fd470) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7830   +/-   ##
=======================================
  Coverage   48.71%   48.72%           
=======================================
  Files         151      151           
  Lines       16287    16263   -24     
=======================================
- Hits         7935     7924   -11     
+ Misses       7387     7376   -11     
+ Partials      965      963    -2

@saschagrunert
Copy link
Member Author

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Remove --seccomp-use-default-when-empty option
03c4bca 
The option has been deprecated for a while and will now be removed in
v1.30.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-integration

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-integration

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a158636 into cri-o:main Mar 1, 2024
65 checks passed
@saschagrunert saschagrunert deleted the seccomp-default-when-empty branch March 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/deprecation lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @kwilczynski