Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI artifact layer cache #7837

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Add OCI artifact layer cache #7837

merged 1 commit into from
Mar 6, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 4, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

We now utilize an on-disk key/value cache for OCI artifacts. The digests will be used to identify if a layer has to be re-pulled or not. The artifact API now returns a path to the file on disk.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added OCI artifact layer cache to avoid repeatedly pulling the same container image.

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 4, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl March 4, 2024 13:09
@openshift-ci openshift-ci bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited

Codecov Report

Merging #7837 (863e514) into main (c0c2b89) will increase coverage by 0.15%.
Report is 8 commits behind head on main.
The diff coverage is 86.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7837      +/-   ##
==========================================
+ Coverage   48.72%   48.88%   +0.15%     
==========================================
  Files         151      151              
  Lines       16265    16339      +74     
==========================================
+ Hits         7925     7987      +62     
- Misses       7377     7388      +11     
- Partials      963      964       +1

@saschagrunert saschagrunert reopened this Mar 4, 2024
@saschagrunert saschagrunert force-pushed the artifact-cache branch 8 times, most recently from 08109d4 to c636d26 Compare March 4, 2024 15:50
@saschagrunert saschagrunert changed the title RFC: Add OCI artifact layer cache Add OCI artifact layer cache Mar 4, 2024
@saschagrunert
Copy link
Member Author

/unhold

ready for review.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
kwilczynski
kwilczynski reviewed Mar 4, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@saschagrunert saschagrunert force-pushed the artifact-cache branch 3 times, most recently from 43fee55 to 29e5f09 Compare March 5, 2024 10:08
@saschagrunert saschagrunert force-pushed the artifact-cache branch 4 times, most recently from 78cd222 to 998b7c1 Compare March 6, 2024 09:11
@saschagrunert
Copy link
Member Author

Added a cache max age. @cri-o/cri-o-maintainers @kwilczynski PTAL again

@saschagrunert
Add OCI artifact layer cache
863e514 
We now utilize an on-disk key/value cache for OCI artifacts. The digests
will be used to identify if a layer has to be re-pulled or not.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/override ci/prow/ci-cgroupv2-integration

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration

In response to this:

/override ci/prow/ci-cgroupv2-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski
Copy link
Member

/remove-label release-note-none
/release-note-edit release-note Add OCI artifact layer cache to avoid repeatedly pulling the same container image.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@kwilczynski: The label(s) /remove-label release-note-none cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label release-note-none
/release-note-edit release-note Add OCI artifact layer cache to avoid repeatedly pulling the same container image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Member

/release-note-edit release-note Add OCI artifact layer cache to avoid repeatedly pulling the same container image.

@saschagrunert, not sure why bot does not seem to do what I ask. 🙂

If you could help me out here. Thank you!

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 6, 2024
@saschagrunert
Copy link
Member Author

Done 👍

@kwilczynski
Copy link
Member

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 534b4a0 into cri-o:main Mar 6, 2024
65 checks passed
@saschagrunert saschagrunert deleted the artifact-cache branch March 6, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwilczynski kwilczynski kwilczynski left review comments

@harche harche harche left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @kwilczynski @harche