-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency update for podman 5 #7852
Conversation
c89446f
to
0543db7
Compare
cd0756e
to
02d90f1
Compare
02d90f1
to
e816682
Compare
e816682
to
306d049
Compare
f4d8857
to
6262730
Compare
355695e
to
4e96903
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7852 +/- ##
=======================================
Coverage 49.85% 49.86%
=======================================
Files 153 153
Lines 16597 16597
=======================================
+ Hits 8275 8276 +1
+ Misses 7302 7301 -1
Partials 1020 1020 |
I think I found the problem. I've looked on the kata side, and found that the CreateRuntime hooks are run at sandbox creation, but not at container creation. Adding the call there fixes the issue. Now for this PR: as our CI is testing only with released versions of kata, and the fix will probably take time to get released, I suggest that you skip this test for now. I will re-enable it when the fix is in the version we use for testing in the CI. |
Great, @littlejawa I'll skip the test but I'll create an issue for anyone to follow up on it when kata is released. |
/test ci-fedora-integration |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold I think @haircommander has mentioned that this needs to go in once 1.30 is wrapped up. Please feel free to unhold once that is the case. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, saschagrunert, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@haircommander can we unhold this? |
not yet, we need to cut 1.30.0 first |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5c5c638
to
1ffa228
Compare
New changes are detected. LGTM label has been removed. |
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
1ffa228
to
05c5cf9
Compare
Now that we have v1.30, we can proceed with this PR. Since Kevin is on PTO, I can help push it to the finish line. |
@cri-o/cri-o-maintainers thoughts? |
Yep, let's get the dependencies up-to-date again! 🙌 |
Closing this in favor of #8133 |
What type of PR is this?
/kind dependency-change
/
What this PR does / why we need it:
Upgrade c/storage and a lot of other dependencies.
Took over from depenabot due to some deprecations.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?