Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update for podman 5 #7852

Closed
wants to merge 1 commit into from

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Mar 6, 2024

What type of PR is this?

/kind dependency-change
/

What this PR does / why we need it:

Upgrade c/storage and a lot of other dependencies.
Took over from depenabot due to some deprecations.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@kannon92 kannon92 requested a review from mrunalp as a code owner March 6, 2024 15:38
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Mar 6, 2024
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from c89446f to 0543db7 Compare March 6, 2024 16:02
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 11, 2024
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from cd0756e to 02d90f1 Compare March 11, 2024 12:41
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 11, 2024
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from 02d90f1 to e816682 Compare March 11, 2024 12:53
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 11, 2024
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from e816682 to 306d049 Compare March 14, 2024 20:24
@kannon92 kannon92 requested a review from fidencio as a code owner March 14, 2024 20:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 14, 2024
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from f4d8857 to 6262730 Compare March 14, 2024 20:27
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 14, 2024
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from 355695e to 4e96903 Compare March 14, 2024 21:06
@kannon92 kannon92 changed the title Dependency update storage 1.53 Dependency update for podman 5 Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #7852 (0283b56) into main (183f28b) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7852   +/-   ##
=======================================
  Coverage   49.85%   49.86%           
=======================================
  Files         153      153           
  Lines       16597    16597           
=======================================
+ Hits         8275     8276    +1     
+ Misses       7302     7301    -1     
  Partials     1020     1020           

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2024
@littlejawa
Copy link
Contributor

I think I found the problem.
The "prestart" hook that we use has been deprecated. The hooks marked for "prestart" are now executed at CreateRuntime (see vendor/github.com/containers/common/pkg/hooks/hooks.go change in your PR).

I've looked on the kata side, and found that the CreateRuntime hooks are run at sandbox creation, but not at container creation. Adding the call there fixes the issue.
I raised an issue on the kata side, and will push a fix ASAP.

Now for this PR: as our CI is testing only with released versions of kata, and the fix will probably take time to get released, I suggest that you skip this test for now. I will re-enable it when the fix is in the version we use for testing in the CI.
Can you look at the contrib/test/ci/vars.list and add hooks.bats to the list of skip files (as there is only one test in it) ? Adding it as part of this PR would make sure we keep track of when/why it's been disabled.

@kannon92
Copy link
Contributor Author

kannon92 commented Apr 19, 2024

Great, @littlejawa I'll skip the test but I'll create an issue for anyone to follow up on it when kata is released.

@kannon92
Copy link
Contributor Author

/test ci-fedora-integration

@kannon92
Copy link
Contributor Author

/retest

Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@kannon92
Copy link
Contributor Author

/hold

I think @haircommander has mentioned that this needs to go in once 1.30 is wrapped up. Please feel free to unhold once that is the case.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@saschagrunert
Copy link
Member

@haircommander can we unhold this?

@haircommander
Copy link
Member

not yet, we need to cut 1.30.0 first

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from 5c5c638 to 1ffa228 Compare April 24, 2024 14:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

New changes are detected. LGTM label has been removed.

Signed-off-by: Kevin Hannon <kehannon@redhat.com>
@kannon92 kannon92 force-pushed the dependency-update-storage-1.53 branch from 1ffa228 to 05c5cf9 Compare April 24, 2024 14:11
@sohankunkerkar
Copy link
Member

Now that we have v1.30, we can proceed with this PR. Since Kevin is on PTO, I can help push it to the finish line.

@sohankunkerkar
Copy link
Member

@cri-o/cri-o-maintainers thoughts?

@saschagrunert
Copy link
Member

saschagrunert commented May 6, 2024

Now that we have v1.30, we can proceed with this PR. Since Kevin is on PTO, I can help push it to the finish line.

Yep, let's get the dependencies up-to-date again! 🙌

@sohankunkerkar
Copy link
Member

Closing this in favor of #8133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/dependency-change Categorizes issue or PR as related to changing dependencies needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants