Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit: Update config and sync to Fedora #7922

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Mar 22, 2024

With this change:

  • COPR builds are now run per-PR
  • Packit will open PRs to the Fedora dist-git repo when a new release is created
  • the %global commit0 value is updated in the specfile for each build

cc @haircommander

What type of PR is this?

/kind ci

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

packit: Update config and sync to Fedora

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 4: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 5: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 6: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 7: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 8: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 9: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

1 similar comment
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 4: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 5: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 6: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 7: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 8: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 9: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/ci Categorizes issue or PR as related to CI labels Mar 22, 2024
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 4: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 5: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 6: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 7: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 8: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 9: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

Hi @LorbusChris. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #7922 (7084db2) into main (93b05e5) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7922   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files         152      152           
  Lines       16447    16447           
=======================================
  Hits         8038     8038           
  Misses       7433     7433           
  Partials      976      976           

@kannon92
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2024
@kannon92
Copy link
Contributor

Please add a release note to the block in the description.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2024
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 4: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 5: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 6: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 7: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 8: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 9: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 4: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 5: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 6: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 7: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 8: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 9: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 4: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 5: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 6: {'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 7: {'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 8: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 9: {'fedora-rawhide': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-40': ["'specfile_path' is not specified or no specfile was found in the repo"], 'fedora-39': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@LorbusChris LorbusChris force-pushed the packit-update branch 7 times, most recently from dd0c3f4 to 9e17d05 Compare March 22, 2024 17:44
@openshift-ci openshift-ci bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Mar 22, 2024
@openshift-ci openshift-ci bot removed the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 22, 2024
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 22, 2024
@LorbusChris LorbusChris force-pushed the packit-update branch 2 times, most recently from aa81b82 to 16fd1d6 Compare March 22, 2024 19:32
@LorbusChris
Copy link
Contributor Author

/packit copr_build

@LorbusChris LorbusChris force-pushed the packit-update branch 4 times, most recently from 3bd8036 to cc12dd3 Compare March 26, 2024 08:00
With this change:
- COPR builds are now run per-PR
- Packit will open PRs to the Fedora dist-git repo when a new release is created
- the `%global commit0` value is updated in the specfile for each build

Signed-off-by: Christian Glombek <cglombek@redhat.com>
@LorbusChris
Copy link
Contributor Author

This should be good to go now. Please take a look if you get a chance @haircommander.

@haircommander
Copy link
Member

/lgtm
/approve

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024
Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@LorbusChris
Copy link
Contributor Author

/retest-required

1 similar comment
@LorbusChris
Copy link
Contributor Author

/retest-required

@haircommander
Copy link
Member

/override ci/prow/ci-fedora-integration

Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-fedora-integration

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

/override ci/prow/ci-cgroupv2-integration

Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-cgroupv2-integration

In response to this:

/override ci/prow/ci-cgroupv2-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

/override ci/prow/e2e-gcp-ovn

Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Contributor Author

/test ci-e2e-evented-pleg

@openshift-merge-bot openshift-merge-bot bot merged commit 5eb4db7 into cri-o:main Mar 30, 2024
69 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants