Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/* to v0.30.0-beta.0 #7935

Closed
wants to merge 2 commits into from
Closed

Bump k8s.io/* to v0.30.0-beta.0 #7935

wants to merge 2 commits into from

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Mar 25, 2024

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

k8s.io/api has been changed since v0.30.0-beta.0.
kubernetes/kubernetes#123435

This PR bumps k8s.io/* packages to the latest and change constants along with that.

Which issue(s) this PR fixes:

None

related to #7931 #7929 #7927 #7926

Special notes for your reviewer:

I looked for the alternative in api but there aren't.

The api change suggests us to use AppArmorProfileType but they are a bit different from the deprecated constants.
https://github.com/kubernetes/kubernetes/blob/634fc1b4836b3a500e0d715d71633ff67690526a/staging/src/k8s.io/api/core/v1/types.go#L4282-L4292

Does this PR introduce a user-facing change?

None

@bitoku bitoku requested a review from mrunalp as a code owner March 25, 2024 21:59
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku
Once this PR has been reviewed and has the lgtm label, please assign hasan4791, nalind for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

Hi @bitoku. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 25, 2024
@kwilczynski
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2024
@kwilczynski
Copy link
Member

@roman-kiselenko, you've been working in this area recently.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #7935 (680cf82) into main (93b05e5) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7935      +/-   ##
==========================================
+ Coverage   48.87%   48.88%   +0.01%     
==========================================
  Files         152      152              
  Lines       16447    16447              
==========================================
+ Hits         8038     8040       +2     
+ Misses       7433     7432       -1     
+ Partials      976      975       -1     

@kwilczynski
Copy link
Member

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@bitoku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-cgroupv2-e2e-crun 680cf82 link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-rhel-e2e 680cf82 link true /test ci-rhel-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@roman-kiselenko
Copy link
Member

/cc @roman-kiselenko

I'm going to wait while this PR to merge and will rebase #7901

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@roman-kiselenko: GitHub didn't allow me to request PR reviews from the following users: roman-kiselenko.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @roman-kiselenko

I'm going to wait while this PR to merge and will rebase #7901

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

Hey @bitoku, thank you for the PR. There is already another one open in #7881

@bitoku
Copy link
Contributor Author

bitoku commented Mar 26, 2024

ah sorry I didn't notice that.
Please feel free to close it if this isn't needed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants