-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io/* to v0.30.0-beta.0 #7935
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bitoku The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @bitoku. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
/ok-to-test |
@roman-kiselenko, you've been working in this area recently. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7935 +/- ##
==========================================
+ Coverage 48.87% 48.88% +0.01%
==========================================
Files 152 152
Lines 16447 16447
==========================================
+ Hits 8038 8040 +2
+ Misses 7433 7432 -1
+ Partials 976 975 -1 |
/retest-required |
@bitoku: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @roman-kiselenko I'm going to wait while this PR to merge and will rebase #7901 |
@roman-kiselenko: GitHub didn't allow me to request PR reviews from the following users: roman-kiselenko. Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ah sorry I didn't notice that. |
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
k8s.io/api has been changed since v0.30.0-beta.0.
kubernetes/kubernetes#123435
This PR bumps k8s.io/* packages to the latest and change constants along with that.
Which issue(s) this PR fixes:
None
related to #7931 #7929 #7927 #7926
Special notes for your reviewer:
I looked for the alternative in api but there aren't.
The api change suggests us to use AppArmorProfileType but they are a bit different from the deprecated constants.
https://github.com/kubernetes/kubernetes/blob/634fc1b4836b3a500e0d715d71633ff67690526a/staging/src/k8s.io/api/core/v1/types.go#L4282-L4292
Does this PR introduce a user-facing change?