Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubelet image GC by using new image_id CRI field #8115

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix kubelet image GC by using new image_id CRI field #8115

merged 1 commit into from
May 3, 2024

Conversation

haircommander
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Using the implementation of kubernetes/kubernetes#123508 to fix #7143

Also incorporating kubernetes/kubernetes#123583 now.

Which issue(s) this PR fixes:

Fixes #7143

Special notes for your reviewer:

taking over #7815

Does this PR introduce a user-facing change?

Fixed kubelet image garbage collection when images being referenced as digests instead of IDs.

@saschagrunert @haircommander
Fix kubelet image GC by using new image_id CRI field
882ce4a 
Using the implementation of kubernetes/kubernetes#123508
to fix cri-o#7143

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 2, 2024
@openshift-ci openshift-ci bot requested review from hasan4791 and QiWang19 May 2, 2024 16:16
@haircommander haircommander added this to the 1.30 milestone May 2, 2024
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2024
sohankunkerkar
sohankunkerkar approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Changes LGTM. I was wondering if we could add an integration test for coverage.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@sohankunkerkar sohankunkerkar mentioned this pull request May 2, 2024
Closed
@haircommander
Copy link
Member Author

/override ci/prow/ci-fedora-integration

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 2, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-fedora-integration

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/retest

saschagrunert
saschagrunert approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/override ci/prow/e2e-gcp-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 3, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/retest

3 similar comments
@saschagrunert
Copy link
Member

/retest

@haircommander
Copy link
Member Author

/retest

@sohankunkerkar
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit d519447 into cri-o:main May 3, 2024
61 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@saschagrunert saschagrunert

@sohankunkerkar sohankunkerkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

imageRef in container status is not image ID and lead to kubelet image gc work abnormally
3 participants
@haircommander @saschagrunert @sohankunkerkar