Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill exec PIDs after main container exited #8162

Merged
merged 1 commit into from
May 15, 2024

Commits on May 10, 2024

  1. Kill exec PIDs after main container exited

    Before applying this patch we killed the exec PIDs right away on
    container stop which leads into the failing e2e test:
    
    ```
    [sig-node] [NodeFeature:SidecarContainers] Containers Lifecycle should terminate sidecars simultaneously if prestop doesn't exit
    ```
    
    This regression is now fixed by killing the exec PIDs after the main
    container as well as in the same thread.
    
    Fixes kubernetes/kubernetes#124743
    Follow-up on cri-o#7937
    
    Needs a cherry-pick since the enhancement got already backported into
    supported release branches.
    
    Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
    saschagrunert committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f03faf9 View commit details
    Browse the repository at this point in the history