-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cgroupPath capability arg #141
Conversation
Add in the plumbing for the cgroupPath capability. Signed-off-by: Casey Callendrello <c1@caseyc.net>
Pull Request Test Coverage Report for Build 4186148033
💛 - Coveralls |
fyi @aditighag |
|
||
// set cgroupPath in Capabilities | ||
if runtimeConfig.CgroupPath != "" { | ||
rt.CapabilityArgs["cgroupPath"] = runtimeConfig.CgroupPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this string exist anywhere we can reference directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that I see; I just followed the existing code that puts capability names here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion for libcni sometime though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than @haircommander comment
/lgtm thanks @squeed ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add in the plumbing for the cgroupPath capability.
Ref: containernetworking/cni#936
There is a similar PR implementing support in go-cni: containerd/go-cni#110