Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault with Java and SSL handling #1481

Closed
michalbiesek opened this issue May 11, 2023 · 2 comments · Fixed by #1479
Closed

Segfault with Java and SSL handling #1481

michalbiesek opened this issue May 11, 2023 · 2 comments · Fixed by #1479
Assignees
@michalbiesek
Milestone
1.3.4

Comments

@michalbiesek
Copy link
Contributor

Reproduction steps:

docker pull jetty
docker run -it  jetty bash
java -jar $JETTY_HOME/start.jar --add-modules=ssl,http2,https,test-keystore
### Copy scope to the new container
scope run -- java -jar $JETTY_HOME/start.jar
# In another terminal
curl -k https://localhost:8443
@michalbiesek michalbiesek self-assigned this May 11, 2023
@michalbiesek michalbiesek linked a pull request May 11, 2023 that will close this issue
Handle BufferAddr in Java Agent #1479
Merged
@michalbiesek michalbiesek added this to the 1.4.0 milestone May 11, 2023
michalbiesek added a commit that referenced this issue May 11, 2023
@michalbiesek
Handle BufferAddr in Java Agent (SSL)
565eae9 
- Do not call `GetPrimitiveArrayCritical` on buffer address
- Perform explicitly memory allocation & copy

Ref: #1481
@michalbiesek
Copy link
Contributor Author

The proper fix was applied with #1479 additionally I've added integration test. The integration test without my fix will result with SIGSEGV

jrcheli pushed a commit that referenced this issue May 24, 2023
@michalbiesek @jrcheli
Handle BufferAddr in Java Agent (SSL)
93da5c3 
- Do not call `GetPrimitiveArrayCritical` on buffer address
- Perform explicitly memory allocation & copy

Ref: #1481
@jrcheli
Copy link
Contributor

jrcheli commented May 24, 2023 •
edited

This work was originally merged into release/1.4.
I cherry-picked this from release/1.4 to master, so it will be included in the 1.3.4 AppScope release.
I changed the Release and Milestone accordingly.

@jrcheli jrcheli modified the milestones: 1.4.0, 1.3.4 May 24, 2023
@jrcheli jrcheli closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalbiesek michalbiesek

Labels
None yet
Projects
No open projects
AppScope 1.3.4
Status: Done
Milestone
1.3.4
Development

Successfully merging a pull request may close this issue.

Handle BufferAddr in Java Agent criblio/appscope
2 participants
@michalbiesek @jrcheli