Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags need to apply to events #149

Closed
coccyx opened this issue Feb 18, 2021 · 1 comment · Fixed by #163
Closed

Tags need to apply to events #149

coccyx opened this issue Feb 18, 2021 · 1 comment · Fixed by #163
Assignees
Labels
Milestone

Comments

@coccyx
Copy link
Collaborator

coccyx commented Feb 18, 2021

Tags set via env var are not applying to events currently, only to metrics. They should appear at the same level of the event as source.

@coccyx coccyx added this to the 0.6 milestone Feb 18, 2021
@jrcheli jrcheli assigned jrcheli and unassigned iapaddler Feb 18, 2021
@jrcheli
Copy link
Contributor

jrcheli commented Feb 26, 2021

I've tested this change with all event types: file, console, metric, http, net, fs, and dns.

As one example of this:
LD_PRELOAD=lib/linux/libscope.so SCOPE_TAG_hey=you SCOPE_EVENT_CONSOLE=true /bin/echo "something"
Outputs:
{"type":"evt","body":{"sourcetype":"console","id":"ubuntu18_4-echo-/bin/echo something","_time":1614357710.803,"source":"stdout","host":"ubuntu18_4","proc":"echo","cmd":"/bin/echo something","pid":110062,"_channel":"1414763257570779","hey":"you","data":"something"}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants