Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope prune with negative arguments #407

Closed
jrcheli opened this issue Jul 19, 2021 · 2 comments · Fixed by #420
Closed

scope prune with negative arguments #407

jrcheli opened this issue Jul 19, 2021 · 2 comments · Fixed by #420
Assignees
@ledbit @seanvaleo
Labels
cli release-note Issues & PRs that should be listed in release notes
Milestone
0.7.2

Comments

@jrcheli
Copy link
Contributor

jrcheli commented Jul 19, 2021

See #358 (comment)
@jrcheli jrcheli added this to the Backlog milestone Jul 19, 2021
@seanvaleo seanvaleo mentioned this issue Jul 26, 2021
Merged
@seanvaleo seanvaleo modified the milestones: Backlog, 0.7.2 Jul 26, 2021
@jrcheli jrcheli added the cli label Jul 29, 2021
@seanvaleo
Copy link
Collaborator

seanvaleo commented Aug 13, 2021 •
edited

QA INSTRUCTIONS

scope prune -k -1

Expect: "error: Must be a positive number"

scope prune -d -1

Expect: "error: Must be a positive number"

@iapaddler iapaddler added the release-note Issues & PRs that should be listed in release notes label Aug 16, 2021
@tvandoren
Copy link

verified 0.7.2-rc3

prune with negative integer arguments shows error message, but works with positive integers

@abetones abetones mentioned this issue Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ledbit ledbit

@seanvaleo seanvaleo

Labels
cli release-note Issues & PRs that should be listed in release notes
Projects
None yet
Milestone
0.7.2
Development

Successfully merging a pull request may close this issue.

Prevent negative numbers in scope prune criblio/appscope
5 participants
@iapaddler @ledbit @tvandoren @seanvaleo @jrcheli