Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update main docs and correct changelog again for 0.7.2 #488

Merged
merged 2 commits into from Aug 18, 2021

Conversation

abetones
Copy link
Collaborator

No description provided.

@abetones
Copy link
Collaborator Author

abetones commented Aug 18, 2021

Per discussion with @jrcheli :

  • #241 ARM64 support — Updated the Requirements page.

  • #395 SCOPE_CONNECT_TIMEOUT_SECS — Added a ¶ in the TLS page.

  • #311 HTTP/1.1 & HTTP/2 traffic — corrected Changelog and added a ¶ in the LogStream Integration page.

  • #407 — updated the CLI reference.

Copy link
Contributor

@mQkatz mQkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@pdugas pdugas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


AppScope streams HTTP payloads to LogStream, whether the payloads originate as HTTP/1.1 or HTTP/2 traffic. LogStream then converts the payloads to HTTP events.

Separately, the AppScope can convert HTTP/1.1 (not HTTP/2) payloads to HTTP events. This is mainly useful for streaming HTTP events to destinations **other than** LogStream.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, AppScope can convert HTTP/1.1 ....


This might not hold true if the command or application being scoped exits quickly and network connection latency is relatively high. Under these conditions, events and metrics can be dropped and never reach the destination.

To mitigate this problem, you can set the `SCOPE_CONNECT_TIMEOUT_SECS` environment variable (which is unset by default) to `1`. Then, the AppScope library will keep the scoped process open for 1 second, which should be enough time for AppScope to connect and stream data over the network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set the variable to N. ... the AppScope library will keep the scoped process open for N second(s)

Copy link
Contributor

@iapaddler iapaddler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a couple of comments. changes requested.

@pdugas pdugas merged commit 3bfa8fb into master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants