Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPS XML respose are missing many metadata field #84

Closed
fmigneault opened this issue Mar 3, 2020 · 0 comments · Fixed by #163
Closed

WPS XML respose are missing many metadata field #84

fmigneault opened this issue Mar 3, 2020 · 0 comments · Fixed by #163
Assignees
Labels
process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support triage/enhancement New feature or request

Comments

@fmigneault
Copy link
Collaborator

fmigneault commented Mar 3, 2020

When calling GetCapabilities, most of the metadata that should be filled by PyWPS configuration are missing (or more often replaced by generic defaults).

Examples :

<ows:ServiceContact>
  <ows:IndividualName>Lastname, Firstname</ows:IndividualName>
  <ows:PositionName>Position Title</ows:PositionName>
  <ows:ContactInfo>
    <ows:Phone>
      <ows:Voice>+xx-xxx-xxx-xxxx</ows:Voice>
      <ows:Facsimile />
    </ows:Phone>
    <ows:Address>
      <ows:DeliveryPoint />
      <ows:City>City</ows:City>
      <ows:AdministrativeArea />
      <ows:PostalCode>Zip or Postal Code</ows:PostalCode
      <ows:Country>Country</ows:Country>
      <ows:ElectronicMailAddress>Email Address</ows:ElectronicMailAddress>
    </ows:Address>
  </ows:ContactInfo>
</ows:ServiceContact>
<wps:Languages>
  <wps:Default>
    <ows:Language>en-US</ows:Language>
  </wps:Default>
  <wps:Supported>
    <ows:Language>lang</ows:Language>
  </wps:Supported>
</wps:Languages>

We need to fill this information from provided metadata config.ini file (done via below code), but maybe we need to enforce it, or otherwise log it with warnings when missing. Maybe some can also be inferred from other configuration values.

weaver/weaver/wps.py

Lines 120 to 128 in 3372fb3

for setting_name, setting_value in settings.items():
if setting_name.startswith("weaver.wps_metadata"):
WEAVER_PYWPS_CFG.set("metadata:main", setting_name.replace("weaver.wps_metadata", ""), setting_value)
# add weaver configuration keyword if not already provided
wps_keywords = WEAVER_PYWPS_CFG.get("metadata:main", "identification_keywords")
weaver_mode = get_weaver_configuration(settings)
if weaver_mode not in wps_keywords:
wps_keywords += ("," if wps_keywords else "") + weaver_mode
WEAVER_PYWPS_CFG.set("metadata:main", "identification_keywords", wps_keywords)

@fmigneault fmigneault added triage/enhancement New feature or request process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support labels Mar 3, 2020
@fmigneault fmigneault self-assigned this Jun 2, 2020
@fmigneault fmigneault mentioned this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support triage/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant