-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor wps-process for workflow steps #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b74dcf
to
201a71f
Compare
…kflow collect output glob (fix #371)
201a71f
to
0a0e3b7
Compare
…ing corresponding process execution tests
dbyrns
reviewed
Jan 6, 2022
dbyrns
reviewed
Jan 6, 2022
dbyrns
reviewed
Jan 7, 2022
dbyrns
reviewed
Jan 10, 2022
dbyrns
reviewed
Jan 10, 2022
dbyrns
reviewed
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a very welcomed refactor!
dbyrns
previously approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you'll fix the monitor interface implementation (bool part), there is nothing more blocking this PR.
dbyrns
previously approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
feature/CWL
Issue related to CWL support
feature/db
Related to database or datatype manipulation.
feature/job
Issues related to job execution, reporting and logging.
feature/oas
Issues related to OpenAPI specifications.
process/builtin
Issue related to builtin application processes
process/workflow
Related to a Workflow process.
process/wps1
Issue related to WPS 1.x processes support
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Each new step process implementation now only requires to implement the specific operations related to deployment,
execution, monitoring and result retrieval for their process, without need to consider Workflow intermediate staging
operations to transfer files between steps.
Wps1Process
andWps3Process
step processes to follow new workflow operation flow.builtin
processfile_index_selector
that allows the selection of a specific file within an array of files.including
WPS-1
,OGC-API
andbuiltin
implementations.CWL
script examples in documentation to separate package files in order to directly reference them intests validating their deployment and execution requests.
tests/functional/application-packages
definitions into distinct directories to facilitate categorizationof corresponding deployment, execution and package contents, and better support the various Workflow testing location
of those files with backward compatibility.
Fixes
CWL
Workflow outputs between steps when nested glob output binding are employed(resolves CWL workflow outputs within nested binding not handled #371).
builtin
process Python reference when executed locally within a Workflow step.WPS-1
from its package within a Workflow step executed asOGC-API
process.WPS1Requirement
directly provided asCWL
execution unit within the deployment body.executionUnit
sub-fields causing potential misinterpretationof the intended application package.
format
reference withinCWL
I/O record after interpretation of the loaded application package.WPS
endpoint responses in generatedOpenAPI
forReadTheDocs
documentation.