Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donations with Stripe credit card processing! #760

Merged
merged 129 commits into from Oct 13, 2018

Conversation

eliduke
Copy link
Collaborator

@eliduke eliduke commented Jun 13, 2018

This PR is getting pretty big, but here are the two main pages that are being added.

The Main Support page where you can give a one-item donation, sign up for a monthly subscription, and also request a link to make changes to an existing subscription:

screen shot 2018-09-18 at 12 31 24 pm

Email with link to Support Edit:

screen shot 2018-09-18 at 1 17 17 pm

The Support Edit page where you can update or cancel a subscription:

screen shot 2018-09-18 at 12 30 55 pm

@CobyR CobyR temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 16:46 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 16:46 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 21:04 Inactive
<button id="js-stripe-button">DONATE</button>

<script>
var handler = StripeCheckout.configure({
Copy link
Collaborator Author

@eliduke eliduke Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone has any ideas as to how to get this out of the view, I'm all ears. The problem is that the:

<script src="https://checkout.stripe.com/checkout.js"></script>

near the top of this file has already loaded and allows for calling StripeCheckout.configure. I'm not sure how to extract everything in the <script> block out into donations.js while still allowing for access to StripeCheckout.

@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 22:15 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 23:24 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 23:53 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 June 13, 2018 23:55 Inactive
@@ -1,4 +1,10 @@
<%= form_tag [:donations] do %>
<%= form_tag [:donations], id: "js-stripe-form" do %>
Copy link
Collaborator

@just1602 just1602 Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know for form that are for external library or other thing like that, but we try to use form_with for the form. If it's specific to Stripe or there is something that you need to do that can't be done with form_with it's cool. Otherwise, consistency would be nice. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally cool! I've been in Rails 4.2 land for a while now with work and just wasn't thinking about it. I'm sure that form_with should be just fine. 👍

@CobyR CobyR temporarily deployed to crimethinc-staging-pr-760 June 21, 2018 23:30 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-760 June 22, 2018 00:42 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-760 June 22, 2018 00:57 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-760 June 22, 2018 01:01 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 07:26 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 07:30 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 07:31 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 07:53 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 08:08 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 08:09 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-760 September 25, 2018 11:56 Inactive
@CobyR CobyR temporarily deployed to crimethinc-staging-pr-760 October 8, 2018 02:02 Inactive
@eliduke eliduke temporarily deployed to crimethinc-staging-pr-760 October 9, 2018 21:31 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-760 October 9, 2018 23:37 Inactive
@veganstraightedge veganstraightedge temporarily deployed to crimethinc-staging-pr-760 October 13, 2018 19:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants