Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout option not working #8

Closed
swapsmagic opened this issue Aug 15, 2012 · 2 comments
Closed

timeout option not working #8

swapsmagic opened this issue Aug 15, 2012 · 2 comments
Labels

Comments

@swapsmagic
Copy link

I tried passing the timeout option to the fbgraph object and looks like it is not being passed to the request object.
And that makes the request not to timeout if the request takes more time that the set by setOptions parameter.

Found the reason looks like due to following line of code:
https://github.com/criso/fbgraph/blob/master/lib/graph.js#L222
Where it is assumped that Graph object will get the same this as the current object, which is not true.

The solution for this is to passing options as parameter to Graph function.

@criso
Copy link
Owner

criso commented Aug 17, 2012

wow. Yeah, no clue what happened there. haha... that would never work.

@swapsmagic
Copy link
Author

#12 to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants