Portable core namespace #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
force-pushed
the
cljx
branch
2 times, most recently
from
8fdfac7
to
2171218
Compare
Middleware not being inserted correctly, and having to repeat plugins as dependencies for some reason
Probably have `core` -> `impl` -> `common`, with a macro to do the bulk imports back into `core`. Yeugh!
CLJX means bringing in pdo or something, and didn't seem to work properly
|
@verma @martinklepsch what do you think of this? is unification worth it? |
Merged
|
Going for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Thought getting feature parity was the hard part.. but exposing a uniform API while breaking up the namespaces nicely is tricky.. Even with help from potempkin, it looks like a mess.
This path is looking dark, think it's time to rethink snubbing inline feature expressions and just go with one-big namespace.
Also auth and offline behaviour have to be covered for JVM case.