Revise treatment of keywords in non-key position #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
force-pushed
the
stable-keywords
branch
from
be04fb4
to
053c5b7
Compare
|
@verma @martinklepsch not sure if this is too magic |
|
Well, I've slept on it and think it's the "right choice". `Will merge and wait for complaints 🐢 |
crisptrutski
added a commit
that referenced
this pull request
Mar 24, 2015
Revise treatment of keywords in non-key position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behaviour seemed very problematic for two reasons:
Since non-keyword strings are highly unlikely to be colon-prefixed, decided to sprinkle some magic when fixing consistency, so that keywords can make a stable round trip.