Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Logger with SLF4J logging framework #99

Closed
abranson opened this issue Dec 17, 2014 · 3 comments
Closed

Replace Logger with SLF4J logging framework #99

abranson opened this issue Dec 17, 2014 · 3 comments
Labels
dev issue for the dev package dsl issue for the dsl package enhancement New feature or request gui issue for the gui package in-memory-lookup issue for the in-memory-lookup package jooqdb issue for the jooqdb package kernel issue for the kernel package lookup-ldap issue for the lookup-ldap package outcomeinit issue for the outcomeinit package restapi issue for the restapi package trigger issue for the trigger package xmldb issue for the xmldb package
Milestone

Comments

@abranson
Copy link
Contributor

The internal logging system should be able to push its log messages to the standard java log framework.

@kovax
Copy link
Member

kovax commented Dec 17, 2014

I would recommend to replace the cristal logging with a standard java
library like SLF4J or Logback:

http://logback.qos.ch/
http://www.slf4j.org/

@kovax kovax transferred this issue from cristal-ise/kernel Feb 15, 2019
@kovax kovax added enhancement New feature or request kernel issue for the kernel package labels Feb 15, 2019
@kovax kovax changed the title Map Logger onto standard logging framework kernel: Map Logger onto standard logging framework Feb 15, 2019
@kovax kovax added this to the 4.0.0 milestone Feb 15, 2019
@kovax kovax changed the title kernel: Map Logger onto standard logging framework kernel: replace Logger with standard logging framework Mar 3, 2019
@kovax
Copy link
Member

kovax commented Mar 3, 2019

  • Make org.cristalise.kernel.utils.Logger deprecated.
    Keep the class for dependent projects and Scripts to use it.
  • Replace all occurrence of org.cristalise.kernel.utils.Logger using Lombok @slf4j
    • kernel
    • jooqdb
    • restapi
    • xpath-outcome-initiator
    • dsl
    • dev
    • testing
    • trigger
    • in-memory-lookup
    • gui
    • lookup-ldap
    • xmldb

@kovax kovax changed the title kernel: replace Logger with standard logging framework kernel: replace Logger with SLF4J logging framework Mar 3, 2019
@kovax kovax changed the title kernel: replace Logger with SLF4J logging framework replace Logger with SLF4J logging framework Mar 3, 2019
@kovax kovax added restapi issue for the restapi package outcomeinit issue for the outcomeinit package jooqdb issue for the jooqdb package dsl issue for the dsl package dev issue for the dev package lookup-ldap issue for the lookup-ldap package xmldb issue for the xmldb package in-memory-lookup issue for the in-memory-lookup package trigger issue for the trigger package gui issue for the gui package labels Mar 3, 2019
@kovax kovax changed the title replace Logger with SLF4J logging framework Replace Logger with SLF4J logging framework Mar 3, 2019
@kovax
Copy link
Member

kovax commented Mar 3, 2019

Perhaps the better choice would be to use Google's Fluent Logger:
https://google.github.io/flogger

Text copied from webstie:

Benefits
While some users prefer “fluency” as a style, this is not what the argument for Flogger rests on. Flogger offers these key, concrete advantages over other logging APIs:

Logging at disabled levels is effectively free. Finally, you can add as many fine-grained log statements to your code as you want, without worry.
Flogger also has very high performance for enabled log statements.
A fluent API accommodates a variety of present and future features without combinatorial explosion, and without requiring separate logging façades.
Less reliance on long parameter lists makes it harder to misuse and yields more self-documenting code.

@kovax kovax modified the milestones: 4.0.0, 4.1.0 Mar 28, 2019
@kovax kovax modified the milestones: 4.1.0, 4.2.0 May 1, 2019
@kovax kovax modified the milestones: 4.2.0, 4.3.0 Jun 11, 2019
kovax added a commit that referenced this issue Jun 23, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
kovax added a commit that referenced this issue Sep 22, 2019
@kovax kovax modified the milestones: 4.4.0, 4.5.0 Nov 8, 2019
kovax added a commit that referenced this issue Nov 30, 2019
kovax added a commit that referenced this issue Dec 7, 2019
kovax added a commit that referenced this issue Dec 7, 2019
@kovax kovax modified the milestones: 4.5.0, 4.6.0 Dec 19, 2019
@kovax kovax modified the milestones: 4.6.0, 5.0.0 Jan 4, 2020
kovax added a commit that referenced this issue Jan 5, 2020
@kovax kovax closed this as completed Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue for the dev package dsl issue for the dsl package enhancement New feature or request gui issue for the gui package in-memory-lookup issue for the in-memory-lookup package jooqdb issue for the jooqdb package kernel issue for the kernel package lookup-ldap issue for the lookup-ldap package outcomeinit issue for the outcomeinit package restapi issue for the restapi package trigger issue for the trigger package xmldb issue for the xmldb package
Projects
None yet
Development

No branches or pull requests

2 participants