Revert and retract typ check #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankdvd
approved these changes
Nov 8, 2023
FZambia
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
I think it's a right decision, I originally was somehow sure it's required by spec and this was a miss from the library. But the spec is clear - it's optional.
And making such check in v5 will cause many inconveniences for users. I think it may be addressed in some other ways in the future for cases when typ value is always known to be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After additional chats and rethinking this should be reverted. Thanks everyone for the input.
Updates #147
Fixes #149
CC: @juliangp @frankdvd