Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback needed #35

Closed
cristianbote opened this issue Mar 28, 2017 · 7 comments
Closed

Feedback needed #35

cristianbote opened this issue Mar 28, 2017 · 7 comments
Assignees

Comments

@cristianbote
Copy link
Owner

Hi there,

So, I'm thinking of rewriting this plugin, completely, but I need feedback, from real world users.

  1. How do you use it on real games?
  2. What needs to be improved?
  3. What's missing?
  4. Is it helpful?

I'm grateful for your answers!

Cheers!

@stephanedemotte
Copy link

A better doc :)

Need to know how we can add our custom transition, could be cool to add this in the current version ;)

@cristianbote
Copy link
Owner Author

cristianbote commented Jun 19, 2017

Hi Stephane,

Thanks for reaching out! Is the custom transition the only thing that's left out? I'm more than happy to address it in the README.md.

Also, would you mind, answering the questions highlighted at the top?

  1. How do you use it on real games?
  2. What needs to be improved?
  3. What's missing?
  4. Is it helpful?

Let me know if there's something else,
Cheers!

@stephanedemotte
Copy link

For the moment, yes ! It's the only thing is missing, for me ;)

I'm very new new in the game dev world.

1 - Yes for a small game for a museum (with physical controls)
2 - I can't say a lot, i'm a noob in phaser.
3 - Like i said, a better doc
4 - Very ! Transition state, is the missing piece in PHASER.State manager

Thanks a lot !

@cristianbote
Copy link
Owner Author

Thank you for all your answers, really appreciate it.
I'll get back with updates.

Thanks

@damienleroux
Copy link

Hello. Here is my feedback:

How do you use it on real games?

I'm using PhaserJs in a React/Cordova env. I'm using react router for navigation between game pages. For now, this router doesn't affect the phaser game dom element. I need to handle transitions on this dom element without react-router. I need a simple fadeIn/fadeOut transition.

What needs to be improved? What's missing?

  • The transition effect speed need to be be controlled (like react router that used react-motion spring function to handle animation stifness and damping). Maybe the props duration does the job. I'll test it.

  • A documentation should explain how to create it own transition, what are the available props and should explain how it affects the game state.

  • Maybe writing ES6 code with a babel parser to create the dist folder could ease the code and offer a better contribution from community.

  • include a default fadeIn/fadeOut transition. If I can create one, I'll make a pull request

Is it helpful?

Yes!! Really. I think it a very good idea to have create it. I don't know if @photonstorm think to include it in phaser 3.

Thank you!

@cristianbote
Copy link
Owner Author

Hey @damienleroux, thank you so much for your feedback and your pull request!

I'm glad it's useful and you use it, I'll take into consideration your points, and as always, if you don't wanna wait for my free time, feel free to submit any pull request.

About the es6 conversion, I have it on my mind since, idk, 2 years ago I think. I created even a project for it, to track the progress, but free time never came around my door 😞 . I have to do it, though, it's getting really obsolete at this point.

Cheers!

@cristianbote
Copy link
Owner Author

Hey guys, finally managed to release a proper es6 version. Is not much, just basically what it was but in es6. I'll get to do some more improvements soon.

Thank you for your feedback, I really appreciate all the feedback and suggestions!

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants