New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation of configured addresses #120

Closed

CastixGitHub opened this issue Jul 6, 2020 · 1 comment · Fixed by #145

Labels

good first issue

Contributor

CastixGitHub commented Jul 6, 2020

shoud block the user immediatly whit urls like

http:/localhost:8080
http:loalhost:8080
http://localhost:
http://localhost:asd

http://localhost:8080/no   <- actually works but adds a leading `/` (needs a separate issue?)
localhost:8080 <- should be guessed it's http?

this should happen when services are added, and at ergo startup

The text was updated successfully, but these errors were encountered:

Owner

cristianoliveira commented Jul 14, 2020

Hey @CastixGitHub thanks for reporting this.
Yeah, I agree, this should be validated! It shouldn't be hard to implement such validations.

cristianoliveira added the good first issue label

cristianoliveira mentioned this issue

fix: invalid service URL causes unhandled exception #145

Merged

cristianoliveira closed this as completed in #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment