Add fmt vet lint #48
Merged
Add fmt vet lint #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds fmt, vet and lint checks for all the tests. This will make sure that no code that does not respect the Golang recomended code style will be submited.
adiclepcea
force-pushed
the
add_fmt_vet_lint
branch
from
aad520a
to
259fa61
Compare
|
It seems that appveyor blocks for some reason. Altough all the tests pass. |
|
Apparently, the integration tests now need admin grants for running and Appveyor doesn't run with those grants. That why it's failing. We have 2 options, discover how to run it as admin in Appveyor or skip this tests on CI and leave them as extra tests. |
|
I will try to figure out how to run with those grants, but for now, I think we may need to skip them. |
|
Fixed the tests :) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fmt, vet and lint checks for all the tests.
This will make sure that no code that does not respect the Golang
recomended code style will be submited.
This should close #47