using rev-parse with ^{commit} instead of new function

cristibalan · Feb 27, 2018 · c484d29 · c484d29
1 parent 65df3bb
commit c484d29
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/lib/braid/command.rb b/lib/braid/command.rb
@@ -114,21 +114,21 @@ def determine_repository_revision(mirror)
       if mirror.tag
         if use_local_cache?
           Dir.chdir git_cache.path(mirror.url) do
-            git.rev_list_1(mirror.local_ref)
+            git.rev_parse(mirror.local_ref + "^{commit}")
           end
         else
           raise BraidError, 'unable to retrieve tag version when cache disabled.'
         end
       else
-        git.rev_list_1(mirror.local_ref)
+        git.rev_parse(mirror.local_ref + "^{commit}")
       end
     end
 
     def validate_new_revision(mirror, revision)
       if revision.nil?
         determine_repository_revision(mirror)
       else
-        new_revision = git.rev_list_1(revision)
+        new_revision = git.rev_parse(revision + "^{commit}")
 
         if new_revision == mirror.revision
           raise InvalidRevision, 'mirror is already at requested revision'

diff --git a/lib/braid/operations.rb b/lib/braid/operations.rb
@@ -223,14 +223,6 @@ def rev_parse(opt)
         raise UnknownRevision, opt
       end
 
-      # git rev-list -1 opt
-      def rev_list_1(opt)
-        opt.insert(0, '-1 ')
-        invoke(:rev_list, opt)
-      rescue ShellExecutionError
-        raise UnknownRevision, opt
-      end
-
       # Implies tracking.
       def remote_add(remote, path)
         invoke(:remote, 'add', remote, path)