Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] tab link break routes #29

Merged
merged 4 commits into from
Dec 6, 2017
Merged

[fix] tab link break routes #29

merged 4 commits into from
Dec 6, 2017

Conversation

ahoendgen
Copy link
Contributor

If you use hash based routes the link on each tab will break the routing, this can be easily fixed with preventing the event to be executed.

@ahoendgen ahoendgen mentioned this pull request Dec 3, 2017
Closed
@cristijora
Copy link
Owner

Hi @ahoendgen Thanks for pointing this out. There is one issue with the PR however. The modification includes only the built common.js file. The modifications should be made on the source files which are located src/components. The files located in dist folder are generated upon npm run build and are used to publish the component to npm. Modifying and committing them directly will not help fixing the issue since these files will be eventually overwritten upon the next update/build.

cristijora
cristijora requested changes Dec 5, 2017
View reviewed changes
dist/vue-tabs.common.js Outdated
@@ -195,6 +195,12 @@ var VueTabs = {
[_this.textPosition === 'top' && _this.renderTabTitle(index, _this.textPosition), h(
'a',
{
on: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a built file. Please do not commit it but rather modify the files inside src folder and commit them instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, my fault, i will change this.

@ahoendgen
Copy link
Contributor Author

btw. is there a reason you didnt add the babel-vue-app-preset to dev-dependencies?
without that i get an error while running yarn install

@cristijora
Copy link
Owner

@ahoendgen you could add that preset to dev deps.

@ahoendgen
Copy link
Contributor Author

@cristijora already did that on my machine, added this also to this mr now

@cristijora cristijora merged commit df24ea2 into cristijora:master Dec 6, 2017
@cristijora
Copy link
Owner

cristijora commented Dec 6, 2017 •
edited
Loading

Great! Thanks. Will release this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristijora cristijora cristijora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahoendgen @cristijora