AuthBehavior optimizations to reduce number of queries. #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main issues:
The first one is that we get all items and iterate over them to get the relations. This one can be suppressed with a plain query to the items child table and getting just the relations between the items.
The second problem is in the displaying the results table:
Method:
AuthItemTypeColumn::renderDataCellContent()
Here we call
hasParent()
orhasChild()
methods which triggersgetItemPermissions()
andgetAuthItem()
methods which queries the database once for each column.(AuthItemTypeColumn
,AuthItemRemoveColumn
,AuthItemDescriptionColumn
). This happens on every row of the result table and leads to poor performance.If we cache the items and their relations when we get the descendants and ancestors this process gets very clean with limited number of queries.