Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation #8

Merged
merged 3 commits into from
Jan 12, 2013
Merged

Russian translation #8

merged 3 commits into from
Jan 12, 2013

Conversation

Ragazzo
Copy link

@Ragazzo Ragazzo commented Jan 12, 2013

Added russian translation and fixed small bug in ukranian translation.

crisu83 added a commit that referenced this pull request Jan 12, 2013
Add russian translation
@crisu83 crisu83 merged commit 847e76c into crisu83:master Jan 12, 2013
@magefad
Copy link
Contributor

magefad commented Jan 15, 2013

Why ru_ru, not ru?! (and see framework messages folder)

@Ragazzo
Copy link
Author

Ragazzo commented Jan 15, 2013

And there different "ru" langs. in russia. see CLDR :) Btw. we have a problem with translations in different cases , i mean "New {type}" message, example:
New role in english is Новая роль (she) in russian, but not Новый роль (he) :( may be add some more translations in code or what do u think @crisu83 ?

@magefad
Copy link
Contributor

magefad commented Jan 15, 2013

If I set language='ru_ru' instead 'ru' in main config - auth module will be in russian, yea. But yii messages in english.
Yii messages in russian only if I set 'ru', not 'ru_ru'!
Understand?

@magefad
Copy link
Contributor

magefad commented Jan 15, 2013

@Ragazzo
Copy link
Author

Ragazzo commented Jan 15, 2013

https://github.com/yiisoft/yii/tree/1.1.13/framework/i18n/data ru,ru_ru,ru_md,ru_ua, understand? :D Да переименуем , главная проблема с падежами как я уже описал выше.

@magefad
Copy link
Contributor

magefad commented Jan 15, 2013

И что с этого?
Главная проблема в том что невозможно видеть перевод без костыля, т.к. с простым указанием ru я уже выше описывал что будет.
А падежи так-то уже второстепенная вещь

@Ragazzo
Copy link
Author

Ragazzo commented Jan 15, 2013

Сделай PR с переименованием папки, потом подумаем над падежами, т.к. это не второстепенная вещь. Лучше завести отдельный issue т.к. тут в закрытом PR писать некошерно.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants