Use two scroll overlays, for separate fixed- and non-fixed column scrolling #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting idea, just to let you know I'll merge this in first chance I get to check over it. Hopefully you're not in a rush, thanks for you patience. |
|
no rush at all thanks.
btw i could imagine you'd want to choose different/better variable & other naming. no offense taken if you do--in the PR i optimized for minimal difference from previous code rather than necessarily trying to come up with something clearest.
… On Dec 20, 2016, at 11:18, Cris Ward ***@***.***> wrote:
Interesting idea, just to let you know I'll merge this in first chance I get to check over it. Hopefully you're not in a rush, thanks for you patience.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Will take a look thank... One thing I've been looking into is, the current scroll detection has a bit of a flaw in that it's impossible to select the content of the cells or use hover in css. I've just has a quick mess of capturing the scroll event with mouse wheel and touch events - see sample here. http://codepen.io/crisward/pen/BQborw It's pretty close, just doesn't have the nice bounce effect on touch devices. I'll probably investigate this more as it may fix #6 too. |
|
see update on issue #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical-only overlay covers the whole width (so that the scrollbar will be on the right) while the horizontal-and-vertical overlay which is above it only covers the non-fixed columns.
This seems to work with the example in
test/index.html, and the existing tests pass. I haven't added any new tests, though probably should.Addresses #18