Search for update only once per run #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,7 @@ def assert_result(action, result) | |||
| end | |||
|
|
|||
| def updates | |||
| @updates ||= [].tap do |updates| | |||
| @@updates ||= [].tap do |updates| | |||
There was a problem hiding this comment.
using run_context should be better here than class variables, especially when chef run as a service daemon
There was a problem hiding this comment.
Ok, using the run_state
Annih
force-pushed
the
search_update_once
branch
from
5c9b46f
to
6f5469c
Compare
|
+1 |
Keep the update found in a class variable, to avoid to search twice.
Annih
force-pushed
the
search_update_once
branch
from
6f5469c
to
3cacd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the update found in a class variable, to avoid to search twice.