feat: add a retry mechanism to retrieve source interface IP #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* getIntfIP func could return an error if the concerned interface is not created yet on the container namespace * add a retry mechanism (10 attempts max) with a sleep interval of 1s to the function getting the interface and its IP address
Lqp1
approved these changes
Jul 26, 2023
|
This PR has been untouched for too long without an update. It will be closed in 7 days. |
|
closing this PR as we found another solution for this (iptables rule) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
route_source_interface_ipv4option on the PTP plugin, and if the interface specified in this option is created by another CNI plugin called simultaneously with the first plugin, there's a good chance that the PTP plugin will return an error because the interface is not yet ready (with a configured IP). To guard against this eventuality, we've implemented a retry mechanism around the code responsible for obtaining the interface's IP address; in the event of an error, it will retry until the maximum retry threshold is reached.Changes: