bgutil: add ways to shard repairs

[iksaif]

See #60.

---

This change is

[iksaif]

@natbraun

---

Review status: 0 of 6 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[natbraun]

Review status: 0 of 6 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

biggraphite/accessor.py, line 726 at r1 (raw file):

        Args:
          start_key: string, start at key >= start_key.
          end_key: string, stop at key == end_key.

Question: shouldn't this be the standard left-inclusive, right-exclusive semantics?

---

biggraphite/metadata_cache.py, line 236 at r1 (raw file):

        Args:
          start_key: string, start at key >= start_key.
          end_key: string, stop at key == end_key.

same as above

---

biggraphite/metadata_cache.py, line 249 at r1 (raw file):

                print (key, value)
                i += 1
                if end_key is not None and key > end_key:

same as above

---

biggraphite/drivers/cassandra.py, line 651 at r1 (raw file):

            result = self.__session.execute(statement, args)

            if not len(result.current_rows):

len == 0 seems better, I think

---

Comments from Reviewable

[iksaif]

Review status: 0 of 6 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

biggraphite/accessor.py, line 726 at r1 (raw file):

Previously, natbraun (Nathaniel Braun) wrote…

Question: shouldn't this be the standard left-inclusive, right-exclusive semantics?

done

---

biggraphite/metadata_cache.py, line 236 at r1 (raw file):

Previously, natbraun (Nathaniel Braun) wrote…

same as above

Done.

---

biggraphite/metadata_cache.py, line 249 at r1 (raw file):

Previously, natbraun (Nathaniel Braun) wrote…

same as above

Done.

---

biggraphite/drivers/cassandra.py, line 651 at r1 (raw file):

Previously, natbraun (Nathaniel Braun) wrote…

len == 0 seems better, I think

Done.

---

Comments from Reviewable

[natbraun]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

biggraphite/metadata_cache.py, line 247 at r2 (raw file):

                    return
            for key, value in cursor:
                print (key, value)

Do we need this print here? If yes, I suggest making it more explicit, like print('Key => value: %s => %s" % (key, value))

---

Comments from Reviewable

[iksaif]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

biggraphite/metadata_cache.py, line 247 at r2 (raw file):

Previously, natbraun (Nathaniel Braun) wrote…

Do we need this print here? If yes, I suggest making it more explicit, like print('Key => value: %s => %s" % (key, value))

Done.

---

Comments from Reviewable

[natbraun]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

biggraphite/accessor.py, line 714 at r3 (raw file):

---

biggraphite/accessor.py, line 721 at r3 (raw file):

        During the repair the keyspace is split in nshards and
        this function will only take car of 1/n th of the data
        as specified by shard. This allows the caller to parallelize

take care

---

Comments from Reviewable

[natbraun]

after my comment is fixed

---

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable