New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TRAVIS in order to test Java tools #188
Conversation
- TOXENV=pylama | ||
- TOXENV=pypy-coverage | ||
- TOXENV=py27-coverage | ||
- JAVA=true TOXENV=pylama # We build Java once only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the java tests in the pylama env is kind of weird.
What do you think about having a fourth case with JAVA=true and TOXENV being null ?
Also maybe we should make JAVA=false implicit.
.travis.yml, line 33 at r1 (raw file): Previously, iksaif (Corentin Chary) wrote…
Currently if JAVA is not specified in the travis matrix, JAVA is tested (so it acts as if true was the default value). I can change that easily. Comments from Reviewable |
.travis.yml, line 33 at r1 (raw file): Previously, mcoolive (Cyril Martin) wrote…
About the mangle Java/Pylama. Separate them seams cleaner. But I don't know how to achieve that in a clean way. What do you mean by "TOXENV being null"? As far I understand, when TOXENV is undefined by travis, tox plays all envs declared in tox.ini. I could wrap the tox command in a "if $PYTHON" or "if ! $ JAVA", but it seams dirty and complex to me. Comments from Reviewable |
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. .travis.yml, line 33 at r1 (raw file): Previously, mcoolive (Cyril Martin) wrote…
What I mean is that this would look cleaner:
Comments from Reviewable |
.travis.yml, line 33 at r1 (raw file): Previously, iksaif (Corentin Chary) wrote…
Done. Comments from Reviewable |
- Specify the version of Python - Specify the version of the JDK, and install it - Add execution of existing Java tests. Run once to save time (on the slave that checks pyjama).
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
slave that checks pyjama).
This change is