Fix parsing of command line parameter overrides using whitespace #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mbompr
reviewed
Sep 29, 2022
| paths, overrides, command = parse_args() | ||
| expected_paths = ["config.yaml"] | ||
| expected_overrides = {"output": "/tmp"} | ||
| expected_command = "run" |
There was a problem hiding this comment.
Maybe it could be worth adding a unit test that covers the case of first example in the doc (https://fromconfig.github.io/#/). In such a case there are two "-".
I don't see why your code would not work in such setting but it is probably worth being sure that doc won't break.
There was a problem hiding this comment.
Good idea! The test case is added by the commit below.
Mbompr
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #37