Support for Tags #26
Merged
Support for Tags #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iksaif
force-pushed
the
tags
branch
2 times, most recently
from
a3e502f
to
0e18318
Compare
Write: - Support tags, in carbon and openmetrics format Read: - Support tags TODO in a later patch: - Support Graphite native Prometheus support: graphite-project/graphite-web#2195 - Support for upcomming Carbon native Prometheus support: graphite-project/carbon#735 - For both of these, just make sure the prefix is handled correctly. Some of this code comes from https://github.com/prometheus/prometheus/pull/3533/files
|
Ready for review now :) |
Thib17
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write:
Read:
TODO in a later patch:
Some of this code comes from https://github.com/prometheus/prometheus/pull/3533/files