Replace Netty by Blaze #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumebort
requested review from
alexeyeryshev,
dufrannea and
haveo
and removed request for
alexeyeryshev and
dufrannea
Netty being pushed based and lolhttp pull based, a lot of complexity was hidden in the Netty integration. Migration were painful as this code was super sensible to race conditions. This commit replace the underlying network & http codec implementation by http4s blaze. At the same time we upgrade cats, cats-effect & fs2 dependencies. - HTTP/2 support is not promoted anymore for now. It is somehow supported by blaze but it requires ALPN support that is not widely supported in Java for now. We will introduce it back later. - Protocol upgrade in user-land API has been removed. It was never used and I'm not sure anymore that it is useful as new protocol seems to favor ALPN anyway. - Auto follow-redirect is not supported anymore when re-using a client directly connected to an host. It does not make sense as redirect to another host is perfectly legit but it can't be handled if the client is connected to a singel host. It was a bug in the initial design.
haveo
approved these changes
Sep 6, 2018
added 2 commits
September 7, 2018 15:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty being pushed based and lolhttp pull based, a lot of complexity
was hidden in the Netty integration. Migration were painful as this
code was super sensible to race conditions.
This commit replace the underlying network & http codec implementation
by http4s blaze. At the same time we upgrade cats, cats-effect & fs2
dependencies.
HTTP/2 support is removed for now. It is somehow supported by blaze
but it requires ALPN support that is not widely supported in Java for
now. We will introduce it back later.
Protocol upgrade in user-land API has been removed. It was never used
and I'm not sure anymore that it is useful as new protocol seems to
favor ALPN anyway.
Auto follow-redirect is not supported anymore when re-using a client
directly connected to an host. It does not make sense as redirect to
another host is perfectly legit but it can't be handled if the client is
connected to a singel host. It was a bug in the initial design.