Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): yargs is incorrecly parsing --version #70

Merged
merged 3 commits into from Jun 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions build.js
Expand Up @@ -541,10 +541,11 @@ module.exports = function (gulpWrapper, ctx) {
ctx.cssAditionalEntryPoints.map(function (entryPoint) {
gulp.src(ctx.baseDir + ctx.sourceFolder + entryPoint)
.pipe(pluginLess({
relativeUrls: true
relativeUrls: true,
javascriptEnabled: true
}))
.pipe(pluginAutoPrefixer({
browsers: ['last 2 versions'] // Could be tweaked according to the browser requisites
browsersList: ['last 2 version'] // Could be tweaked according to the browser requisites
}))
.pipe(gulp.dest(ctx.baseDir + ctx.deployFolder + "src"));
});
Expand All @@ -566,15 +567,15 @@ module.exports = function (gulpWrapper, ctx) {
javascriptEnabled: true
})).on('error', function (err) { callback(err) })
.pipe(pluginAutoPrefixer({
browsers: ['last 2 versions'] // Could be tweaked according to the browser requisites
browsersList: ['last 2 version'] // Could be tweaked according to the browser requisites
})).on('error', function (err) { callback(err) })
.pipe(pluginRename(ctx.packageName + '.css'))
.pipe(gulp.dest(ctx.baseDir + ctx.deployFolder + "src"));
} else {
return gulp.src(ctx.baseDir + ctx.sourceFolder + '**/*.less')
.pipe(pluginLess()).on('error', function (err) { callback(err) })
.pipe(pluginAutoPrefixer({
browsers: ['last 2 versions'] // Could be tweaked according to the browser requisites
browsersList: ['last 2 version'] // Could be tweaked according to the browser requisites
})).on('error', function (err) { callback(err) })
.pipe(gulp.dest(ctx.baseDir + "src"));
}
Expand Down
6 changes: 5 additions & 1 deletion install/package.management.js
Expand Up @@ -5,9 +5,13 @@ var fs = require("fs"),
pluginExecuteSync = require("child_process").execSync,
pluginfsExtra = require("fs-extra"),
pluginPath = require('path'),
pluginYargs = require('yargs').argv,
pluginYargs = require('yargs'),
gulpUtil = require("gulp-util");

// Disable --version parse for Yargs so that we can use --version for our own purposes.
pluginYargs.version(false);
pluginYargs = pluginYargs.argv;

// List of packages that are allowed to be linked outside the project
const EXTERNAL_LINK_IGNORE_LIST = [];

Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "@criticalmanufacturing/dev-tasks",
"version": "7.0.0-3",
"version": "7.0.0-4",
"description": "Gulp tasks and helpers for development",
"main": "main.js",
"dependencies": {
Expand Down