Rebuild of the app #429

mltbnz · 2021-12-30T11:08:24Z

📝 Docs

Did you update the CHANGELOG.md?

📲 What

This is essentially a rebuild of the App built with The Composable Architecture and SwiftUI. The project consists of a Swift package which bundles the individual modules for the app. Building the app in modules allows to work on features without building the entire application, which improves compile times and SwiftUI preview stability. Also every feature is its own target which makes it also possible to build mini-apps to run in the simulator for preview.

Missing
The Friends feature is currently missing.

🤔 Why

Maintaining the codebase became a bit hard and since I decided I wanted to keep maintaining the project I wanted a codebase which is both maintainable and modern to work on. There are a lot of benefits as well:

uniform feature architecture
high testability
modularisation
enables easy porting to other platforms
managing dependencies and side effects in an understandable way

👀 See

Screenshots, external resources?

Added snapshot tests

♿️ Accessibility

Tap targets use minimum of 44x44 pts dimensions
Works with VoiceOver
Supports Dynamic Type

🔄 Review & Merge

This PR will replace all files on main and therefore needs to be merged forcefully. I preserved the current state of the app on the branch release/3.9.2 to keep around.
Review of the code is optional but I would like you to check out the branch, launch the so the see if anything pops out that needs fixing. Before a potential release I would also like to do a new version for Testflight and maybe a tweet so we might get some people to test this rebuild.

+ add tests + add coordinate obfuscation

* pull decode upstream

* info bar wip * add cm infobar icon * setup infobar window in scenedelegate * permanantly get user locations * fix apirequest and nextRideRequest * update styleguide * add infobar tests * fix next ride * update info bar and add swipe * add infobannercontroller mock * update infobar tests * fix container viewController * update adding child controller structure * update swipe up trigger value * inject date as func * use styleguide values * add infobar testtarget to testplane * add trackingMode delegate and set binding value * remove dead code * use styleguide grid * update mapview edges * fix tests * fix mktrackingmode reset * bump deployment to ios 14 * move resources to styleguide * add cm annotation to map * update Assets to L10n

when tapping on the infobar it swipes out of the screen and the nextRide gets focused on the map

create snapshot tests for existing views

+ also adds a custom navigationbar + update backgroundSecondary color

* update test * fix colors to test on none beta versions * test * update ci yaml 1 * update ci yaml 2 * update ci yaml 3 * update ci yaml * update fastlane * upload artifacts when failure * upload artifacts when failure * update snapshots * set xcode setup * disable snapshot tests for now

* add GuideFeature to Package * add images for guide feature * add GuideFeature components * setup navigationView to navigate to GuideView * add dismissable modifier * remove dismissable from detailview * set toolbaritem placement

@main

* add settings target * add settingsview * update settings views * add support section colors * add support section icons * remove tca import to make it build * open settings from appnavigationview * update a11y * add infosection * set version and build number * add SettingFeatureTests * add settingsFeatureCore and link with views all openURL commands open a url * update app assets * add fileClient * add appIcon select WIP * add helpers * update helpers package * update tests * remove infobarcontroller in favor of @main app * update helper * update packages * temp infobar fix * tests * save selected theme to userSettings and use light textcolor * fix in favour of CI Version * fix appIcon settings + add appearance tests * fix app feature tests + add userSettingsLoaded receiver * add custom dump package * add event settings view * appearance updates * Update main.yml (#420) * Update Gemfile.lock * Update main.yml update Xcode version * Update main.yml * Update main.yml * update event settings enable copy * update settings + add event settings * update settings views * add event settings tests * update toggle color * update settings + remove openurl type from settingsnavigationlink + fix supports views alignment * minor ui tweaks * refactor appearance core * add settings snapshot tests * update ui * update testplan * refactor rideeventsettings + add core and connect rideeventreducer to settingsreducer * update snapshot tests + use only one device for tests + update sloppy precision to 0.99

* only set unread messages when chat view is not presented * docs 📝 * test ✅

* fix animation by using .onChange and internal @State properties

- license - code of conduct - changelog

fbernutz · 2022-01-02T09:56:10Z

Hey @mltbnz!
Amazing job with the rewrite! 👏

I just had a look at it (finally) and here's some small feedback:

The failing test AppNavigationViewSnapshotTests.test_appNavigationView_WithBadge() in the CI fails locally for me as well when I run with Xcode 13.2.1 and iPhone 8 Plus with latest iOS, maybe it's because of the precision of 95%?
The switch for the observation mode in settings can't be activated with voice over 🤔 (1)
Maybe we can switch from HStack to VStack for the TweetView when the user is using an accessibilitySize with isAccessibilityCategory? (2)
All elements of a tweet are accessible on their own, so navigating with voice over is a bit hard on the list. Maybe we can group the elements similar to the old/current version? (3)
The GuideDetailView needs to have a ScrollView for larger font sizes, otherwise text will be truncated. (4)

I think all of these issues can be fixed in a later version as well. The rest looks really great already! ✨ Thumbs up from me!

Some screenshots:

1	2	3	4

mltbnz · 2022-01-02T12:47:14Z

Thanks. The points should be fixed easily so I'll address them in this PR.

The failing test is currently a bit of a mystery. Don't get why these are different on the CI run. I recorded the Snapshots with an iPhone 12 btw. I'll update the PR template.

The toggle action hopefully is just an accessibilityAction modifier 😄

fbernutz · 2022-01-02T13:03:15Z

Mhmmm that's weird, the test even fails on iPhone 12 for me on my machine.

mltbnz · 2022-01-02T14:54:05Z

Ok. Then I should double check it again if what I have checked in is even valid 🙈

+ combine child elements + make metadata stack aware of dynamicType size

mltbnz · 2022-01-02T20:09:39Z

seems like my update snapshot fixed it 🎉
I addressed the issues. Thanks for taking the time to check it out.

Do you have an idea what would be the best way to merge it back to main?

fbernutz · 2022-01-04T09:08:34Z

@mltbnz Amazing!

Not sure if this is the easiest way but I would go with this:

on develop branch: merge in the main branch with "ours" merge strategy, git merge -s ours main for solving the conflicts
from Github UI or locally on main branch: do a merge commit or squashed commit to merge develop into main

I think the most important thing is to not force push the main branch, so others don't have to fix their local branches.

mltbnz added 30 commits June 12, 2021 12:19

setup for rebuild

e3e0752

update nextRideCore

9ddd647

+ add tests + add coordinate obfuscation

update appcorefeature

50db331

add core tests and a bit of refactoring

f74bacf

extract app navigation view

31be2e4

add a11y

16ff2c6

add localized strings

b78f95e

update ApiClient

100d454

* pull decode upstream

set decode strategy

5e60182

add nextRideReducer

cca50bb

minor refactor

5046bfa

add pathmonitor client

f1bc37d

add map info view

d6f0af1

update tests

04c0658

adding tests and update L10n

98bb614

update L10n

e8dba3b

some clean up

e84bdf8

add focusNextRideFeature

323b417

when tapping on the infobar it swipes out of the screen and the nextRide gets focused on the map

add snapshot dependency

eb15f12

create snapshot tests for existing views

add basic sheet navigation (#412)

7cc10c8

+ also adds a custom navigationbar + update backgroundSecondary color

update ci

094bef1

add gemfile and README

d3feb7a

Guide feature (#414)

01f2a5b

* add GuideFeature to Package * add images for guide feature * add GuideFeature components * setup navigationView to navigate to GuideView * add dismissable modifier * remove dismissable from detailview * set toolbaritem placement

twitter feed (#424)

2ff2fd8

Feature/Chat (#426)

ab0ed0a

chat feature leftovers

876bfb6

* only set unread messages when chat view is not presented * docs 📝 * test ✅

remove infoBar code

c9e3287

mltbnz added 12 commits December 27, 2021 20:03

update MapOverlayView and move it to the MapFeature

13d2101

* fix animation by using .onChange and internal @State properties

update set first expanded state

73e56ac

update center next ride focus span

da548c0

update snapshots for ride event settings

179e587

adopt reduceMotion a11y settings 👁

19b7786

Rename onPush to onPush.yml

efe35e6

add swiftgen to tools and add Makefile

ff84621

add Acknowledgementsview 📄

af9135d

increase tap area for nav buttons

61e8c82

add markdown files

eb8f46d

- license - code of conduct - changelog

update workflows

75d8830

update snapshots

90a199d

mltbnz requested a review from a team as a code owner December 30, 2021 11:08

mltbnz changed the title ~~Develop~~ Rebuild of the app Dec 30, 2021

update snapshots

c99ccda

mltbnz added 5 commits January 2, 2022 20:51

wrap detailview in scrollview

3a69c59

add accessibilityAction modifier to observation mode

594d45e

update A11y for TweetView

ab5d50f

+ combine child elements + make metadata stack aware of dynamicType size

appnavview with badge snapshot update

e51feaf

Update pull_request_template.md

24be8b2

mltbnz merged commit f339e39 into main Jan 4, 2022

mltbnz deleted the develop branch January 4, 2022 10:59

mltbnz restored the develop branch January 4, 2022 11:01

mltbnz mentioned this pull request Jan 4, 2022

Road to 4.0 #409

Closed

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild of the app #429

Rebuild of the app #429

mltbnz commented Dec 30, 2021 •

edited

Loading

fbernutz commented Jan 2, 2022 •

edited

Loading

mltbnz commented Jan 2, 2022

fbernutz commented Jan 2, 2022

mltbnz commented Jan 2, 2022

mltbnz commented Jan 2, 2022

fbernutz commented Jan 4, 2022 •

edited

Loading

Rebuild of the app #429

Rebuild of the app #429

Conversation

mltbnz commented Dec 30, 2021 • edited Loading

📝 Docs

📲 What

🤔 Why

👀 See

♿️ Accessibility

🔄 Review & Merge

fbernutz commented Jan 2, 2022 • edited Loading

mltbnz commented Jan 2, 2022

fbernutz commented Jan 2, 2022

mltbnz commented Jan 2, 2022

mltbnz commented Jan 2, 2022

fbernutz commented Jan 4, 2022 • edited Loading

mltbnz commented Dec 30, 2021 •

edited

Loading

fbernutz commented Jan 2, 2022 •

edited

Loading

fbernutz commented Jan 4, 2022 •

edited

Loading