This repository has been archived by the owner on Apr 30, 2023. It is now read-only.
scrollable videos page insde iframe like the one on http://criticalmass-berlin.org/map-gallery/ #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephanlindauer This will break things. You have to scroll the window and not the video wrapper to trigger the JS window scroll event that is necessary for lazy loading more videos. By testing this with the embedded iframe you can simulate it. Is there any bug you've wanted to fix with this change? (If so, we have to look for another solution) |
|
the problem i was trying to fix was that on the website i have put as thw title of this pr, you cant scroll the videos because there is no scrollbar. |
|
will close this for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.