pdf_new_name #89
Merged
pdf_new_name #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
commented
Sep 21, 2019
| @@ -1156,31 +1129,40 @@ pub unsafe extern "C" fn pdf_set_string( | |||
| }; | |||
| } | |||
| /* Name does *not* include the /. */ | |||
| #[no_mangle] | |||
| pub unsafe extern "C" fn pdf_new_name(mut name: *const i8) -> *mut pdf_obj { | |||
| pub unsafe fn pdf_new_name(name: &str) -> *mut pdf_obj { | |||
There was a problem hiding this comment.
pdf_new_name splitted on pdf_new_name(name: &str) and pdf_copy_name(name: *const i8).
Use Rust allocator.
|
Generally pdfobj stuff would be superseded by #73 |
|
This moves call sites in the right direction so good, but probably don’t go too far down the pdfobj rabbit hole |
That's why I I do it by small steps. |
|
Seems good, merging~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.