This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
CIDetector as a Singleton #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core Image Contexts/Detectors should be initted (yes that's made up) as sparsely as possible. The reason being is each time you init one you're using GPU compute and memory. This competes with a things like UIScrollViews which are very GPU intensive. CIDetector is still very resource hungry and I've only tested this code on an iPad Air for performance where its usable, around 40fps rather than 60fps.
| options:opts]; | ||
|
|
||
|
|
||
| if (!detector) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the CIDetector as a singleton as there was some overhead in the creation of new CIDetectors which Apple's Documentation recommends against.
https://developer.apple.com/library/ios/documentation/CoreImage/Reference/CIDetector_Ref/Reference/Reference.html
This should improve the performance of UIImageViews inside scroll views.